[dev] [carhartlewis] lewis/comp-skills-fix#2679
Merged
carhartlewis merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
- Introduced AGENTS.md to outline project rules, tooling, code style, authentication, API architecture, RBAC, design system, data fetching, testing, database, and Git practices. - Added SKILL.md files for various auditing skills including design system compliance, hooks and API usage patterns, RBAC, unit tests, and more. - Established clear conventions for new feature setup, Prisma schema management, and infrastructure practices. This documentation aims to enhance consistency and quality across the codebase, ensuring all contributors adhere to established standards.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
13 issues found across 36 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".agents/skills/data/SKILL.md">
<violation number="1" location=".agents/skills/data/SKILL.md:31">
P2: The example destructures `updateTask` from `useTasks`, but the hook example does not return `updateTask`.</violation>
</file>
<file name=".agents/skills/trigger-advanced-tasks/SKILL.md">
<violation number="1" location=".agents/skills/trigger-advanced-tasks/SKILL.md:45">
P2: Tag length limit is documented incorrectly (64 instead of 128), which can lead to over-restrictive validation logic.</violation>
<violation number="2" location=".agents/skills/trigger-advanced-tasks/SKILL.md:408">
P2: The Usage Monitoring example uses `logger` but does not import it, so the snippet is invalid as written.</violation>
</file>
<file name="AGENTS.md">
<violation number="1" location="AGENTS.md:7">
P2: This command uses `npx`, which conflicts with the stated "bun only" tooling rule in this file.</violation>
<violation number="2" location="AGENTS.md:9">
P3: Replace `npx` with `bunx` here to align with the bun-only package manager rule.</violation>
</file>
<file name=".claude/skills/infra/SKILL.md">
<violation number="1" location=".claude/skills/infra/SKILL.md:33">
P3: Update the `packages/ui` description to reflect that it is legacy and that `@trycompai/design-system` is preferred.</violation>
</file>
<file name=".claude/skills/prompt-engineering/SKILL.md">
<violation number="1" location=".claude/skills/prompt-engineering/SKILL.md:39">
P3: The section title says there are 8 core techniques, but only 6 are present in the file.</violation>
</file>
<file name=".claude/skills/prisma/SKILL.md">
<violation number="1" location=".claude/skills/prisma/SKILL.md:54">
P2: The “Always Do This” example says to regenerate types in all apps, but it omits `apps/portal`, which conflicts with the rest of the document and can leave one app with stale Prisma types.</violation>
</file>
<file name=".claude/skills/trigger-basic/SKILL.md">
<violation number="1" location=".claude/skills/trigger-basic/SKILL.md:160">
P3: The `wait.until` example uses a hard-coded past date, so it won’t actually wait in current/future usage.</violation>
</file>
<file name=".agents/skills/prisma/SKILL.md">
<violation number="1" location=".agents/skills/prisma/SKILL.md:54">
P2: The "Always Do This" commands are inconsistent with the rest of the file: it says to regenerate in all apps but omits `apps/portal`, which can leave that app’s Prisma types stale.</violation>
</file>
<file name=".claude/skills/trigger-advanced-tasks/SKILL.md">
<violation number="1" location=".claude/skills/trigger-advanced-tasks/SKILL.md:408">
P2: The usage-monitoring example uses `logger` without importing it, so the snippet is invalid as written.</violation>
</file>
<file name=".agents/skills/forms/SKILL.md">
<violation number="1" location=".agents/skills/forms/SKILL.md:56">
P2: Rename the second schema constant to avoid redeclaration in the same snippet.</violation>
</file>
<file name=".agents/skills/audit-design-system/SKILL.md">
<violation number="1" location=".agents/skills/audit-design-system/SKILL.md:23">
P2: Use Bun tooling instead of `npx` to match repository package manager conventions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
- Replaced `npx` with `bunx` in various SKILL.md files to standardize command usage for typechecking and testing across the codebase. - Updated AGENTS.md to reflect the new command format for running typechecks and tests in the app and API directories. - Clarified the preferred usage of `@trycompai/design-system` over `@trycompai/ui` in infrastructure documentation.
Contributor
|
🎉 This PR is included in version 3.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge lewis/comp-skills-fix into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Adds comprehensive project rules and agent skills to standardize design system usage, data patterns, RBAC, testing, and Trigger.dev across the monorepo. Also switches all docs and skills to
bun/bunxcommands and clarifies prioritizing@trycompai/design-systemover legacy@trycompai/ui.bun), code style, auth, API/RBAC, design system, data fetching, testing, DB, and Git..agents/skillsand mirrored in.claude/skillsfor DS migration to@trycompai/design-system(replacing@trycompai/uiandlucide-react), hooks/data (SWR,apiClient), RBAC/audit logs, forms (RHF + Zod), Prisma, infra, UI rules, code standards, prompt practices, and Trigger.dev (basic, advanced, realtime, scheduled, config).bun/bunx(typecheck, tests); clarified DS over legacy UI; updated rules/examples (data hook addsupdateTask, Prisma regen includesapps/portal, Trigger.dev tags max 128 chars, improved wait.until example, realtime install viabun add).Written for commit 2da22b6. Summary will update on new commits. Review in cubic